Conversation
next up: handle background retirement
helper functions for image retirement. not expected to be used in transations
* to enable an upgrade test * to enable web backwards compatibility
| "nounsDAOLogicV1": "0xa43aFE317985726E4e194eb061Af77fbCb43F944" | ||
| }, | ||
| "4": { | ||
| "nounsToken": "0x632f34c3aee991b10D4b421Bc05413a03d7a37eB", |
There was a problem hiding this comment.
@solimander is it important to keep the original values here before merging to master?
There was a problem hiding this comment.
It's okay to keep the new Rinkeby contract addresses as long as they're targeted in the subgraph that's used in the webapp.
| { | ||
| "network": "rinkeby", | ||
| "nounsToken": { | ||
| "address": "0xc52bb4Fc4ed72f2a910BF0481D620B927Ded76f7", |
There was a problem hiding this comment.
@solimander is it important to revert these values before merging to master?
There was a problem hiding this comment.
Related to #499 (comment), we can keep these new values as long as the new values also remain in the SDK.
…epo into verbs-descriptor-v2
using sdk version 0.2.0 with multiline rle encoding
| .addOptionalParam('auctionDuration', 'The auction duration (seconds)', 600, types.int) | ||
| .addOptionalParam('timelockDelay', 'The timelock delay (seconds)') | ||
| .addOptionalParam('votingPeriod', 'The voting period (blocks)') | ||
| .addOptionalParam('votingDelay', 'The voting delay (blocks)') | ||
| .addOptionalParam('votingPeriod', 'The voting period (blocks)', 5760, types.int) | ||
| .addOptionalParam('votingDelay', 'The voting delay (blocks)', 1, types.int) |
There was a problem hiding this comment.
Didn't add defaults here so the default values in the deploy task would be used. Is there an issue with those? Vaguely remember some type issue.
There was a problem hiding this comment.
@eladmallel do you remember why these were added?
|
Is it worthwhile to think about including a naming extension as well with this for properties? #479 |
@iainnash Appreciate the contribution, but it's the wish of the Noun artists that the trait names do not appear in the metadata. |
not specifying default values falls back on the default values in the deploy task
5 participants
A new descriptor version that allows for significantly cheaper deployment of the Nouns art and better composability by improving the external API.
The new contracts provides the following benefits:
Cheaper deployment cost: ~13.8M gas instead of ~67.3M gas
Easier composability for external contracts by splitting the tokenURI construction to several contracts
Full tech spec: https://github.com/nounsDAO/nouns-tech/blob/main/descriptor-v2/README.md
This also introduces some fixes to the art.